Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psse: full export to version 35 #3334

Draft
wants to merge 72 commits into
base: main
Choose a base branch
from
Draft

Psse: full export to version 35 #3334

wants to merge 72 commits into from

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Feb 25, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

Full export is not supported. Only the update is available when the IIDM is the result of importing a previous PSS/E model.

What is the new behavior (if this is a feature change)?

Full export to version 35 is also available. Both formats, RAW and RAWX, are supported.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

marqueslanauja and others added 30 commits March 21, 2024 15:05
@marqueslanauja
copy of the imported PSSE model to make the updates and export (deep …
b0c2d98 
…copy)

Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into psse_copy
7947a24
@marqueslanauja
Merge branch 'main' into psse_copy
3d106ed
@marqueslanauja
Import and update substation data
362d13f 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Remove duplicated code
5e93847 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smells
cab4aa1 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smells
67ff326 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
nodeBreaker convert
b39afef 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smells
b74848e 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Add tests. Last changes
e896564 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smells
b2203bc 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert
cff26cf
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert
0162bad
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert
57362ce
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert
8ad9c73 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>

# Conflicts:
#	psse/psse-converter/src/test/java/com/powsybl/psse/converter/PsseExporterTest.java
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert
decd4b8 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>

# Conflicts:
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/BusConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/FixedShuntCompensatorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/GeneratorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/LineConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/LoadConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/PsseExporter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/SwitchedShuntCompensatorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java
#	psse/psse-converter/src/test/java/com/powsybl/psse/converter/PsseExporterTest.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/PssePowerFlowModel.java
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert
786bc59
@marqueslanauja
full export. First version
1f71051 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Minor changes in ContextExport
47f2df2 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Reorganize code
5aeb31d 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Minor changes
3dd3d88 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
LoadConvert
c424ea2 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Bus converter
2e5d7a1 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Create fixedShunts
244f71e 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fixed Shunt. Define fieldNames
e8667b1 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
create generators
470846e 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Create Lines
4c2e4ae 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Clean code
f27b818 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Full export. Transformers
d1a9f96 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Full export. Lines: findRates
d765d7c 
Signed-off-by: marquesja1 <marquesja@aia.es>
marqueslanauja and others added 29 commits September 13, 2024 10:20
@marqueslanauja
create default methods for all converters
bde67af 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
FullExport: FactsDevices
e22b79f 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Create TieLines
68ac48d 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
TieLine minor changes
a35700c 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
FullExport: batteries
179c7b7 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Full Export: DanglingLines
97636a2 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Improvements
74afe02 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
c1bf28b 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Comment clarification
32a178b 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert_improvements
1ef0dda
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert_improvements
02ddcf5
@marqueslanauja
Merge branch 'main' into psse_nodeBreaker_convert_improvements
84549bb
@marqueslanauja
Minor change
4187dec 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'psse_nodeBreaker_convert_improvements' into psse_full_e…
c4232fe 
…xport

Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/ContainersMapping.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/AbstractConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/BusConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/ContextExport.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/FixedShuntCompensatorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/GeneratorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/LineConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/LoadConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/NodeBreakerImport.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/NodeBreakerValidation.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/PsseExporter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/PsseImporter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/SlackConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/SwitchedShuntCompensatorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/TwoTerminalDcConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/VoltageLevelConverter.java
#	psse/psse-converter/src/test/java/com/powsybl/psse/converter/PsseImporterTest.java
#	psse/psse-converter/src/test/resources/IEEE_118_bus.xiidm
#	psse/psse-converter/src/test/resources/IEEE_14_bus.xiidm
#	psse/psse-converter/src/test/resources/IEEE_14_bus_nodeBreaker_rev35.xiidm
#	psse/psse-converter/src/test/resources/IEEE_14_buses_duplicate_ids.xiidm
#	psse/psse-converter/src/test/resources/IEEE_14_buses_duplicate_ids_rev35.xiidm
#	psse/psse-converter/src/test/resources/IEEE_14_buses_zip_load.xiidm
#	psse/psse-converter/src/test/resources/IEEE_14_isolated_buses.xiidm
#	psse/psse-converter/src/test/resources/IEEE_24_bus.xiidm
#	psse/psse-converter/src/test/resources/IEEE_57_bus.xiidm
#	psse/psse-converter/src/test/resources/IsolatedSlackBus.xiidm
#	psse/psse-converter/src/test/resources/RawCaseWithSpecialCharacters.xiidm
#	psse/psse-converter/src/test/resources/SwitchedShunt.xiidm
#	psse/psse-converter/src/test/resources/SwitchedShuntWithZeroVswlo.xiidm
#	psse/psse-converter/src/test/resources/ThreeMIB_T3W_modified.xiidm
#	psse/psse-converter/src/test/resources/ThreeMIB_T3W_phase.xiidm
#	psse/psse-converter/src/test/resources/TransformersWithZeroNomV.xiidm
#	psse/psse-converter/src/test/resources/TwoWindingsTransformerPhase.xiidm
#	psse/psse-converter/src/test/resources/five_bus_nodeBreaker_rev35.xiidm
#	psse/psse-model/src/main/java/com/powsybl/psse/model/io/LegacyTextReader.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/PsseFixes.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/PsseSubstation.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/io/SubstationData.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/io/TwoTerminalDcTransmissionLineData.java
#	psse/psse-model/src/test/java/com/powsybl/psse/model/PsseRawDataTest.java
#	psse/psse-model/src/test/resources/IEEE_14_bus_nodeBreaker_rev35.json
#	psse/psse-model/src/test/resources/five_bus_nodeBreaker_rev35.json
@marqueslanauja
Merge branch 'main' into psse_full_export
4c929c1
@marqueslanauja
Pretty code
025290a 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Copy PsseFacts
a14f29b 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
13766d6 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
404286c 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
ccf6b95 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issue
52a9ed6 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Reduce the complexity
fd93a2d 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Final tests and improvements
dc954de 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into psse_full_export
43a5af5 
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/AbstractConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/BusConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/ContextExport.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/FixedShuntCompensatorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/GeneratorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/LineConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/LoadConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/PsseExporter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/PsseImporter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/SlackConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/SwitchedShuntCompensatorConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/TwoTerminalDcConverter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/VoltageLevelConverter.java
#	psse/psse-converter/src/test/resources/IEEE_14_buses_duplicate_ids_rev35.xiidm
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/PsseFixes.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/PssePowerFlowModel.java
#	psse/psse-model/src/main/java/com/powsybl/psse/model/pf/PsseValidation.java
@marqueslanauja
Fix issues
b712452 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
extend badly connected equipment and badly defined controlled buses t…
d80434d 
…o VscDcTransmissionLines and FactsDevices

Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
add more unit tests
69787ea 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Improve unit tests
405ceae 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into psse_full_export
f37fe4b
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marqueslanauja