[WIP] Use i18n #3349
Draft
[WIP] Use i18n #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
…ose the report nodes keys Signed-off-by: CARON Alice <alice.caron@rte-france.com>
…method for ReportNodes Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
|
flo-dup
reviewed
Mar 10, 2025
| @@ -23,58 +24,58 @@ private CgmesReports() { | |||
| // INFO | |||
| public static ReportNode applyingPreprocessorsReport(ReportNode reportNode) { | |||
| return reportNode.newReportNode() | |||
| .withMessageTemplate("applyingPreprocessors", "Applying preprocessors.") | |||
| .withLocaleMessageTemplate("core-cgmes-conversion-applyingPreprocessors", ReportBundleBaseName.BUNDLE_BASE_NAME) | |||
There was a problem hiding this comment.
it's a bit strange to have snake-case mixed with camelCase 🐍🐫
Could you use the dot character instead of the dash?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
follow PR #3299 to internationalize
ReportNodeWhat kind of change does this PR introduce?
Refactor existing ReportNode to use the new method
withLocaleMessageTemplateto be able to use dictionnary (Resource bundle).What is the current behavior?
I18N not possble for
ReportNodeWhat is the new behavior (if this is a feature change)?
I18N possble for
ReportNodeDoes this PR introduce a breaking change or deprecate an API?