Add geographical layout for NAD #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
tadam50
force-pushed
the
113-allow-change-of-layout-for-nad
branch
from
b22921e to
d02c30e
Compare
So-Fras
previously requested changes
Apr 24, 2024
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/nad/NetworkAreaDiagramModel.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
tadam50
force-pushed
the
113-allow-change-of-layout-for-nad
branch
from
1fc0748 to
6b33e5c
Compare
flo-dup
reviewed
Apr 26, 2024
| public LayoutFactory getLayoutFactory() { | ||
| return BASIC_LAYOUT.equals(layoutFactory.getValue()) ? new BasicForceLayoutFactory() : null; | ||
| public LayoutFactory getLayoutFactory(Network network) { | ||
| // FIXME : user must be able to customize positions |
There was a problem hiding this comment.
indeed! myabe we could have an open file dialog then, to choose a data file. But we still have to define the format. As this feature is already needed now in the viewer, let's keep that for later
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
approved these changes
Apr 26, 2024
flo-dup
changed the title
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
flo-dup
dismissed
So-Fras’s stale review
So-Fras requests have been taken into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
'Fixes #113 '