Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size and grid fitting cells #271

Closed
flo-dup opened this issue Sep 1, 2021 · 0 comments · Fixed by #347
Closed

Size and grid fitting cells #271

flo-dup opened this issue Sep 1, 2021 · 0 comments · Fixed by #347
Assignees

Comments

@flo-dup
Copy link
Contributor

flo-dup commented Sep 1, 2021

  • Do you want to request a feature or report a bug?
    Feature

  • What is the current behavior?
    Grid is displayed on each side of bus bars even if no cells up or bottom
    SVG size has similar problems

  • What is the expected behavior?
    Grid not displayed above (resp. under) the busbars if no cells above (resp. under)
    SVG size fitting for those 2 cases

  • What is the motivation / use case for changing the behavior?
    Size / grid fitting to have a nice looking diagram

  • Other information
    When drawing the grid, VoltageLevelGraph::getExternCellHeight(direction) can be used.
    For the size I think we only need to adapt PositionVoltageLevelLayout::calculateExternCellHeight to keep 0 value if no BusCell of specific direction

flo-dup added a commit that referenced this issue Sep 1, 2021
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added a commit that referenced this issue Sep 1, 2021
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added a commit that referenced this issue Sep 1, 2021
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added a commit that referenced this issue Sep 9, 2021
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants