Indentation #165
Merged
Indentation #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
indentation
branch
from
c1dfd48 to
5ed3d08
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
geofjamg
approved these changes
Sep 18, 2020
BenoitJeanson
pushed a commit
that referenced
this pull request
Sep 24, 2020
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong indentation in svg diagram was because of the text nodes in the svg basic components. Indeed, empty text nodes were kept and the transformer does not manage them. This PR looks for empty nodes and delete them after loading each component. Another way would have been to validate the content of the svg component while loading it.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Wrong indentation in produced svg
What is the new behavior (if this is a feature change)?
Correct indentation
Does this PR introduce a breaking change or deprecate an API?
No
Other information:
Note that the high number of lines modified is because of the svg test files.