Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified edge color in case one of the extremities is an open switch #170

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

niconoir
Copy link
Contributor

@niconoir niconoir commented Oct 7, 2020

Signed-off-by: NOIR Nicolas ext nicolas.noir@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR fixes a bug

What is the current behavior? (You can also link to an open issue here)
Currently, some wires surrounding an open switch are not correctly colored (i.e. are not colored according to their voltage level)

What is the new behavior (if this is a feature change)?
Wires surrounding an open switch are now colored according to their voltage level.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: NOIR Nicolas ext <nicolas.noir@rte-france.com>
Signed-off-by: NOIR Nicolas ext <nicolas.noir@rte-france.com>
@niconoir niconoir requested a review from geofjamg October 9, 2020 13:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

35.3% 35.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@geofjamg geofjamg merged commit 684ae4a into master Oct 9, 2020
@geofjamg geofjamg deleted the fix_topological_coloring branch October 9, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants