use ServiceLoader.load with the current classloader instead of the context classloader #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext classloader The context classloader can be the wrong one (and ServiceLoader.load returns an empty list) when you are calling ServiceLoader.load in the ForkJoinPool.commonPool() (or any other thread pool) and you have your classes in another classloader than the AppClassLoader (=system classloader). This is the case when using a springboot fat jar, or when deploying the code in a war in an application server, or when using mvn exec:java Signed-off-by: Jon Harper <jon.harper87@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
May 12, 2021
flo-dup
requested changes
May 12, 2021
|
@flo-dup ServiceLoaderCache was modified in core powsybl/powsybl-core#1727 so it should be fixed when we upgrade |
flo-dup
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context classloader can be the wrong one (and ServiceLoader.load returns an empty list)
when you are calling ServiceLoader.load in the ForkJoinPool.commonPool() (or any other thread pool)
and you have your classes in another classloader than the AppClassLoader (=system classloader).
This is the case when using a springboot fat jar, or when deploying the code in a war in an application
server, or when using mvn exec:java
Signed-off-by: Jon Harper jon.harper87@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restpowsybl/powsybl-core#1727