Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user id in FeederInfo, ElectricalNodeInfo and NodeLabel #290

Merged
merged 13 commits into from
Oct 29, 2021
Merged

Add user id in FeederInfo, ElectricalNodeInfo and NodeLabel #290

merged 13 commits into from
Oct 29, 2021

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented Oct 15, 2021 •
edited by flo-dup
Loading

Signed-off-by: Thomas ADAM tadam@silicom.fr

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
Fix '#287'

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@tadam50
Add all FeederInfo into metadata
88796f5 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 requested a review from flo-dup October 15, 2021 14:41
@tadam50 tadam50 self-assigned this Oct 15, 2021
@tadam50
Update GraphMetadataTest
8ce0a70 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
flo-dup
flo-dup reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for adding the feederValue parameters to the metadata, they were missing indeed!

@tadam50
Add id on FeederInfo
79c2421 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix metadata test results
93fe23e 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Add NodeLabelMetadata
461c7d3 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Add ElectricalNodeInfoMetadata
a2fc1d7 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
flo-dup
flo-dup requested changes Oct 26, 2021
View reviewed changes
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultDiagramLabelProvider.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/FeederInfo.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/FeederInfo.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DiagramLabelProvider.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java Outdated Show resolved Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java Outdated Show resolved Hide resolved
@tadam50
Taking into account PR reviews
ce686ad 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Taking into account PR reviews
23ce091 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@flo-dup flo-dup linked an issue Oct 29, 2021 that may be closed by this pull request
Add measure id #287
Closed
@tadam50 tadam50 requested a review from flo-dup October 29, 2021 09:14
@tadam50
Remove left, right label & direction from Feeder metadata
c97e0ed 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Add distance into Feeder metadata -> needed by dev-tools
018176b 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 force-pushed the issue_287_add_feeder_value_id branch from b33db5e to 018176b Compare October 29, 2021 09:31
@flo-dup flo-dup marked this pull request as ready for review October 29, 2021 09:34
@tadam50
getNodeId renamed to getNodeLabelId + move initProvider.getNodeLabels
1a37992 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 requested a review from flo-dup October 29, 2021 13:02
@flo-dup
Revert "Add distance into Feeder metadata -> needed by dev-tools"
ab1e06a 
This reverts commit 018176b.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the issue_287_add_feeder_value_id branch from 98928da to ab1e06a Compare October 29, 2021 13:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 5fa8a72 into main Oct 29, 2021
@flo-dup flo-dup deleted the issue_287_add_feeder_value_id branch October 29, 2021 13:17
@flo-dup flo-dup mentioned this pull request Oct 29, 2021
Merged
3 tasks
@flo-dup flo-dup changed the title Add feeder value id #287 Add user id in FeederInfo, ElectricalNodeInfo and NodeLabel Oct 29, 2021
@flo-dup flo-dup mentioned this pull request Nov 10, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

Assignees

@tadam50 tadam50

Labels
PR: waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add measure id
2 participants
@tadam50 @flo-dup