Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BranchStatus code smells #305

Merged
merged 1 commit into from
Nov 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
*/
public interface BranchStatus<C extends Connectable<C>> extends Extension<C> {

static final String NAME = "branchStatus";
String NAME = "branchStatus";

public enum Status {
enum Status {
IN_OPERATION,
PLANNED_OUTAGE,
FORCED_OUTAGE
Expand All @@ -29,5 +29,5 @@ default String getName() {

Status getStatus();

BranchStatus setStatus(Status status);
BranchStatus<C> setStatus(Status status);
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public Status getStatus() {
return status;
}

public BranchStatus setStatus(Status branchStatus) {
public BranchStatus<C> setStatus(Status branchStatus) {
Objects.requireNonNull(branchStatus);
this.status = branchStatus;
return this;
Expand Down