Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busbar anchors #337

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Fix busbar anchors #337

merged 7 commits into from
Feb 11, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 18, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Some anchors are missing on BusNodes, leading to graceless lines over the bus for extern cells with two feeders for instance (the lines are seen with BasicStyleProvider only, otherwise they are not seen because of the same colour as the bus)

What is the new behavior (if this is a feature change)?

  • Adding missing anchors
  • Not adding line in SVG if zero-length

Does this PR introduce a breaking change or deprecate an API?
No

flo-dup and others added 7 commits January 10, 2022 15:09
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 8790ed1 into main Feb 11, 2022
@flo-dup flo-dup deleted the fix_busbar_anchors branch February 11, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant