Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor direction #338

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Refactor direction #338

merged 3 commits into from
Mar 25, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 18, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Refactor / feature

What is the current behavior?
Only BusCell has direction

What is the new behavior (if this is a feature change)?
Any Cell now has a direction, which might be Direction.UNDEFINED though.

Does this PR introduce a breaking change or deprecate an API?
No, as BusCell.Direction is still valid, as BusCell extends Cell

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@flo-dup
Direction moved from BusCell to Cell
8c8df08 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added 2 commits March 25, 2022 17:49
@flo-dup
Do not serialize direction if UNDEFINED
3079d24 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update unit tests
3778e5c 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 7407993 into main Mar 25, 2022
@flo-dup flo-dup deleted the refac_direction branch March 25, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flo-dup