Adding order and direction to SwitchNode serialization #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-dup
changed the title
flo-dup
requested changes
Feb 8, 2022
There was a problem hiding this comment.
Thanks for fixing that bug! One more thing, could you amend your commit to add your signoff? and then force-push (see DCO details for more info if needed)
single-line-diagram-core/src/main/java/com/powsybl/sld/model/SwitchNode.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/model/SwitchNode.java
Outdated
Show resolved
Hide resolved
* Adding feederInfosIntraMargin parameter in LayoutParameters * Rename feederArrowSymmetry to feederInfoSymmetry in LayoutParameters * Rename arrowDistance to feederInfosOuterMargin in LayoutParameters * Rename minSpaceForFeederArrow to spaceForFeederInfos in LayoutParameters * Rename Arrow to FeederInfo in DefaultSVGWriter * Rename Arrow to FeederInfo in LayoutParameters * Add new test with 5 feeder info Signed-off-by: Thomas ADAM <tadam@silicom.fr> Signed-off-by: Marin Pinchinat-Loth <marin.pinchinat@rte-france.com>
Signed-off-by: Marin Pinchinat-Loth <marin.pinchinat@rte-france.com>
* Creates coordinate package and populates it * Decoupling Cell dependency to VoltageLevelGraph * Clean up unused attribute in VoltageLevelGraph * Remove unused vPosToHPosToNodeBus in VoltageLevelGraph * Merge Graph&LineGraph and AbstractGraph & AbstractLineGraph * Explicitly type MiddleTwtNode when necessary * Initialize the nodes of the Cell when building Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com> Signed-off-by: Marin Pinchinat-Loth <marin.pinchinat@rte-france.com>
MarinPinchinatLoth
force-pushed
the
fix_switch_node_serialization
branch
from
673ceff to
053cf85
Compare
…ng methods from super Signed-off-by: Marin Pinchinat-Loth <marin.pinchinat@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
approved these changes
Feb 11, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem ?
Yes, fixes #340 by adding optional order and direction to SwitchNode serialization.