Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip provider #368

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Tooltip provider #368

merged 7 commits into from
Mar 10, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Mar 10, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
Tooltip content is hard coded (name of the node)

What is the new behavior (if this is a feature change)?
Tooltip content is provided by the DiagramLabelProvider for each Node

Does this PR introduce a breaking change or deprecate an API? Yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

flo-dup added 4 commits March 10, 2022 10:56
@flo-dup
Add interface
b9d8a41 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove LayoutParameters.tooltipEnabled
ece7553 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add the tooltip in the SVG using labelProvider
f0635cd 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update tooltip unit test
017e8a7 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup and others added 2 commits March 10, 2022 15:54
@flo-dup
Merge branch 'main' into tooltip_provider
e0e4bbc
@flo-dup
Fix code smell
be87ce3 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove tooltip for decorators, feederInfo, busInfo
7630a7a 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit d68b3e1 into main Mar 10, 2022
@flo-dup flo-dup deleted the tooltip_provider branch March 10, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flo-dup