Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VoltageLevelGraph::getCells #379

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Remove VoltageLevelGraph::getCells #379

merged 2 commits into from
Mar 25, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Mar 25, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Feature / refactor

What is the current behavior?
VoltageLevelGraph::getCells is called when one wants:

  • a stream of BusCell
  • or a stream of ShuntCell
  • or a stream of intern cells
  • or a stream of extern cells

Each time a new TreeSet is created copying the existing TreeSet and then the same filtering is writing again and again.

What is the new behavior (if this is a feature change)?
VoltageLevelGraph::getCellStream is deleted and the following methods introduced:

  • VoltageLevelGraph::getCellStream
  • VoltageLevelGraph::getShuntCellStream
  • VoltageLevelGraph::getBusCellStream
  • VoltageLevelGraph::getExternCellStream
  • VoltageLevelGraph::getInternCellStream

Does this PR introduce a breaking change or deprecate an API?
No, internal API

flo-dup added 2 commits March 25, 2022 17:10
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 61776c9 into main Mar 25, 2022
@flo-dup flo-dup deleted the cell_stream branch March 25, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant