Fix missing shape #405
Merged
Fix missing shape #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In |
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
vertical detection done also on UNDEFINED shapes in Subsection Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
fix_missing_crossover
branch
from
ed2f5e2 to
bfafb77
Compare
BenoitJeanson
approved these changes
Jul 13, 2022
| // if more than one bus on one side, the intern cell is | ||
| // - either crossover (two sections): detected later in Subsection::identifyCrossOverAndCheckOrientation | ||
| // - or vertical (one section): detected later in Subsection::identifyVerticalInternCells | ||
| if (candidateLegs.stream().map(LegBlock::getBusNodes).allMatch(bn -> bn.size() == 1)) { |
There was a problem hiding this comment.
At first sight, an UNILEG could be tagged as MAYBEFLAT if it is connected to a single bus (this case is actually very weird), maybe you should perform the test on UNILEG first
There was a problem hiding this comment.
Yes, indeed, good catch! But as this is unrelated to current issue and as it implies deeper changes, I'll create an issue about that.
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
fix_missing_crossover
branch
from
389c77a to
f228695
Compare
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Shape missing on specific intern cells, leading to erroneous diagrams:
What is the new behavior (if this is a feature change)?
Shape added
Does this PR introduce a breaking change or deprecate an API?
No