Fix two-winding transformers static definition in style provider #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
added a commit
that referenced
this pull request
Oct 5, 2022
* StyleProvider default implementation more overridable * Update test references as line feeder nodes have no vl style anymore Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In the default StyleProvider implementation, the 2-winding transformers are detected to put the appropriate voltage level style:
This detection is based on 2-winding transformers component name with the use of a static method, which leaves no space for the custom 2-winding transformers.
What is the new behavior (if this is a feature change)?
In the default StyleProvider implementation, the detection of 2-winding transformers and more generally the nodes connecting two voltage levels is now based on the FeederNode::getFeeder instance. Besides, this detection can be overridden as the corresponding
AbstractBaseVoltageDiagramStyleProvider::isNodeConnectingVoltageLevelsvisibility isprotected.Does this PR introduce a breaking change or deprecate an API?
No