Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topological style #445

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Fix topological style #445

merged 6 commits into from
Nov 17, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Nov 17, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
Yes, fixes #431

What is the current behavior?
Coloring of bus nodes and branches based on nominal voltage connected components

What is the new behavior (if this is a feature change)?
Coloring based on bus nodes on each voltage level, for a given nominal voltage all branches have the same color

screenshot

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from geofjamg November 17, 2022 10:12
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit f8c8247 into main Nov 17, 2022
@flo-dup flo-dup deleted the topological_style branch November 17, 2022 13:45
@flo-dup flo-dup mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve TopologicalStyleProvider
1 participant