Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of quick intro + update on website link #455

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Dec 12, 2022

Signed-off-by: Sophie Frasnedo sophie.frasnedo@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update on the readme.md:

  • A small intro with a picture of both available diagrams has been added;
  • Network-area diagrams are presented first;
  • A link to the PowSyBl website has been updated.

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras requested a review from flo-dup December 12, 2022 20:58
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@flo-dup
Copy link
Contributor

flo-dup commented Dec 14, 2022

Just realized that the network-area diagram displayed are not so good-looking, maybe we should replace IEEE30 with IEEE300, which looks a lot nicer

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
…page and adding link to NAD tutorial on PowSyBl website

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras requested a review from flo-dup December 20, 2022 14:32
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…sion on svg format given

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras requested a review from flo-dup January 4, 2023 12:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@flo-dup flo-dup merged commit e6098e3 into main Jan 4, 2023
@flo-dup flo-dup deleted the readme_update branch January 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants