Edge parts can be stretchable or glued #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luma <zamarrenolm@aia.es>
3 tasks
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
I just added some minor modifications:
- drawEdgeInfo should always add the edge info style, therefore the styles passed as parameters are only additional styles
- it makes more sense to put the pst arrow in the same svg group as the windings
- there was one extra svg group in each winding to add the glued center class, but that class can be concatenated to the other classes of the winding
- the converter station has been forgotten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luma zamarrenolm@aia.es
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the new behavior (if this is a feature change)?
Some parts of the edge drawings are marked as
stretchableorglued.This information helps to update the diagram when the user interacts with it.
In the basic use-case is a user wants to move some node locations and see the effects (immediately) in the diagram.
To provide this kind of interaction, we want to allow the user drag the nodes to their desired positions. The edges connected to the moved node must be updated (if possible, while the user is performing the drag operation).
To be able to properly update the different parts of the edge we label them using two classes:
stretchable: this part of the edge drawing can be scaled to fill the new gap between end nodes.glued: this part of the edge is glued to one of the ends of the edge or to its center.Other information:
Previously the symbol for the transformer was split in two drawings, each one contained in its half edge.
With this change the circle drawings for the transformer symbol are grouped together in an element that then is glued to center of the edge.