Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix nad layout instability #491

Closed
wants to merge 1 commit into from
Closed

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Jan 29, 2023

Signed-off-by: Sophie Frasnedo sophie.frasnedo@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#470

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Copy link
Member Author

So-Fras commented Feb 3, 2023

This method does not seem conclusive. Using a VoltageLevelFilter instead of a Predicate<VoltageLevel> in NetworkGraphbuilder prevents the user from creating a custom filter (similar to what is done in LayoutwithInitialPositionsTest with vl -> vl.getNominalV() >= 100).

@So-Fras So-Fras closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant