[SLD] 237 animate feeder arrows #500

tadam50 · 2023-02-13T09:28:38Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#237

tadam50 · 2023-02-13T16:42:21Z

Breaking changes is raised here by adding new parameter into
public List<String> getFeederInfoStyles(FeederInfo info, boolean animated)
This new parameter is added to use LayoutParameter::isEnableFeederInfosAnimation()

So-Fras

Thank you for your work so far. We must clear up some specifications for you to be able to go on with the development.
Moreover, we did not realize at first that this feature could bring a breaking change.

So-Fras · 2023-02-14T16:16:31Z

...e-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DiagramStyles.java

@@ -46,6 +46,14 @@ public final class DiagramStyles {
    public static final String ANGLE = STYLE_PREFIX + "angle";
    public static final String FEEDER_INFO = STYLE_PREFIX + "feeder-info";

+    public static final String ARROW_ANIMATION = STYLE_PREFIX + "arrow-animation";
+
+    public static final String ARROW_ANIMATION_SPEED_1 = STYLE_PREFIX + "arrow-animation-speed-1";


We have to decide how to discretize the power values and maybe include "no value" or "zero power" cases.

So-Fras

I made very few comments. Thank you for your nice work!

...le-line-diagram-core/src/main/java/com/powsybl/sld/util/AnimatedFeederInfoStyleProvider.java

single-line-diagram/single-line-diagram-core/src/main/resources/animations.css

So-Fras

Everything is OK for me!

flo-dup · 2023-03-20T16:10:24Z

single-line-diagram/single-line-diagram-core/src/main/resources/animations.css

+.sld-arrow-animation-low-speed { --sld-arrow-animation-parameters: 3s infinite linear }
+.sld-arrow-animation-average-speed { --sld-arrow-animation-parameters: 2s infinite linear }
+.sld-arrow-animation-high-speed { --sld-arrow-animation-parameters: 1s infinite linear }
+.sld-arrow-animation-no-speed { --sld-arrow-offset-path: path('') }


You could do it simpler by using a not operator instead of introducing one more variable --sld-arrow-offset-path, for instance:

.sld-cell-direction-top .sld-arrow-in :.sld-arrow-animation-no-speed { offset-rotate: 0deg; offset-path: path('M 0,-10 0,10'); animation: move var(--sld-arrow-animation-parameters, 0s); }

flo-dup · 2023-03-20T16:13:40Z

single-line-diagram/single-line-diagram-core/src/test/resources/TestAnimatedFeederInfos.svg

This file is not working on my firefox 96.0, the bottom black arrow is pointing to the top instead of to the bottom. It seems that the rotate is overriden. But in the specifications it is written that:

Note: The rotation described here does not override or replace any rotation defined by the transform property.

So, if it still occurs on a more recent version of firefox, we should report it to mozilla bug report.

On Firefox ESR 102.9.0 (March 14, 2023) same issue

Thanks for testing!

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

…nts library Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

…tion Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

flo-dup

Just 2 typos and we're good!

flo-dup · 2023-03-23T16:41:56Z

...le-line-diagram-core/src/main/java/com/powsybl/sld/util/AnimatedFeederInfoStyleProvider.java

@@ -0,0 +1,75 @@
+/**
+ * Copyright (c) 2019, RTE (http://www.rte-france.com)


Replace with 2023. Besides we've been asked to add * SPDX-License-Identifier: MPL-2.0 at the end to ease up license scanning

flo-dup · 2023-03-23T16:42:43Z

...ine-diagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestFeederInfos.java

+        network.getLoad("l2").getTerminal().setP(501.0);
+        network.getLoad("l2").getTerminal().setQ(0.0);
+
+        // Enable animation


You can remove this comment

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

sonarqubecloud · 2023-03-27T15:58:54Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

* Use new AnimatedFeederInfoStyleProvider for animation * Add 2 thresholds in AnimatedFeederInfoStyleProvider constructor * Update svg test reference files * HvdcTest : fix svg generation at any time Signed-off-by: Thomas ADAM <tadam@silicom.fr> Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>

* Use new AnimatedFeederInfoStyleProvider for animation * Add 2 thresholds in AnimatedFeederInfoStyleProvider constructor * Update svg test reference files * HvdcTest : fix svg generation at any time Signed-off-by: Thomas ADAM <tadam@silicom.fr>

tadam50 linked an issue Feb 13, 2023 that may be closed by this pull request

Animate feeder arrows #237

Closed

tadam50 self-assigned this Feb 13, 2023

tadam50 changed the title ~~237 animate feeder arrows~~ [SLD] 237 animate feeder arrows Feb 13, 2023

tadam50 added SLD Breaking change labels Feb 13, 2023

tadam50 requested review from So-Fras and flo-dup February 13, 2023 16:34

tadam50 marked this pull request as ready for review February 13, 2023 16:34

tadam50 force-pushed the 237-animate-feeder-arrows branch from c6ec577 to 5c2733c Compare February 13, 2023 17:16

So-Fras requested changes Feb 14, 2023

View reviewed changes

So-Fras requested changes Feb 23, 2023

View reviewed changes

...le-line-diagram-core/src/main/java/com/powsybl/sld/util/AnimatedFeederInfoStyleProvider.java Outdated Show resolved Hide resolved

single-line-diagram/single-line-diagram-core/src/main/resources/animations.css Outdated Show resolved Hide resolved

tadam50 removed the Breaking change label Feb 23, 2023

tadam50 force-pushed the 237-animate-feeder-arrows branch from 0e41afc to bcbdcb5 Compare February 27, 2023 08:41

tadam50 added the PR: waiting-for-review label Feb 27, 2023

tadam50 requested a review from So-Fras February 27, 2023 11:11

So-Fras approved these changes Mar 2, 2023

View reviewed changes

flo-dup requested changes Mar 20, 2023

View reviewed changes

tadam50 added 8 commits March 23, 2023 14:00

HvdcTest : fix svg generation at any time

9478dcd

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

First try to animate feeder infos arrows using test resources compone…

87c22ee

…nts library Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Add & use rotation info

a8fc76d

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Use new StyleManager instead of new Library

e863312

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Update svg test reference files

2dd8d2f

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Add 2 thresholhs in AnimatedFeederInfoStyleProvider constructor

9a45b39

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Taking into account MR comments: nominal renamed to average

7d86081

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Taking into account MR comments: do not apply offet on no speed anima…

7a4087b

…tion Signed-off-by: Thomas ADAM <tadam@silicom.fr>

tadam50 force-pushed the 237-animate-feeder-arrows branch 2 times, most recently from 59bc015 to 67f8f01 Compare March 23, 2023 15:44

Use :not(.sld-arrow-animation-no-speed) instead of new CSS variable

2f3b9ca

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

tadam50 force-pushed the 237-animate-feeder-arrows branch from 67f8f01 to 2f3b9ca Compare March 23, 2023 15:50

flo-dup reviewed Mar 23, 2023

View reviewed changes

Taking into account PR comments on typo

0d8083a

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

flo-dup approved these changes Mar 27, 2023

View reviewed changes

flo-dup merged commit ba104bc into main Mar 27, 2023

flo-dup deleted the 237-animate-feeder-arrows branch March 27, 2023 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SLD] 237 animate feeder arrows #500

[SLD] 237 animate feeder arrows #500

tadam50 commented Feb 13, 2023

tadam50 commented Feb 13, 2023 •

edited

Loading

So-Fras left a comment

So-Fras Feb 14, 2023

So-Fras left a comment

So-Fras left a comment

flo-dup Mar 20, 2023

flo-dup Mar 20, 2023

tadam50 Mar 23, 2023

flo-dup Mar 23, 2023

flo-dup left a comment

flo-dup Mar 23, 2023

flo-dup Mar 23, 2023

sonarqubecloud bot commented Mar 27, 2023

		@@ -0,0 +1,75 @@
		/**
		* Copyright (c) 2019, RTE (http://www.rte-france.com)

[SLD] 237 animate feeder arrows #500

[SLD] 237 animate feeder arrows #500

Conversation

tadam50 commented Feb 13, 2023

tadam50 commented Feb 13, 2023 • edited Loading

So-Fras left a comment

Choose a reason for hiding this comment

So-Fras Feb 14, 2023

Choose a reason for hiding this comment

So-Fras left a comment

Choose a reason for hiding this comment

So-Fras left a comment

Choose a reason for hiding this comment

flo-dup Mar 20, 2023

Choose a reason for hiding this comment

flo-dup Mar 20, 2023

Choose a reason for hiding this comment

tadam50 Mar 23, 2023

Choose a reason for hiding this comment

flo-dup Mar 23, 2023

Choose a reason for hiding this comment

flo-dup left a comment

Choose a reason for hiding this comment

flo-dup Mar 23, 2023

Choose a reason for hiding this comment

flo-dup Mar 23, 2023

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 27, 2023

tadam50 commented Feb 13, 2023 •

edited

Loading