feat: add current info #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hervé <herve.quarton@soprasteria.com>
hquarton
force-pushed
the
add-current-info
branch
from
0c1a279 to
fb3bb5f
Compare
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
…layed by default) Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Mar 20, 2023
network-area-diagram/src/main/java/com/powsybl/nad/svg/AbstractStyleProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
flo-dup
requested changes
Mar 20, 2023
.../single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultDiagramLabelProvider.java
Outdated
Show resolved
Hide resolved
.../single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultDiagramLabelProvider.java
Outdated
Show resolved
Hide resolved
.../single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultDiagramLabelProvider.java
Outdated
Show resolved
Hide resolved
.../single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultDiagramLabelProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
…abel + update test references Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Apr 3, 2023
...ine-diagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestFeederInfos.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/test/java/com/powsybl/nad/svg/TypeOfEdgeInfoTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Just realizing it's a bit strange to display current with an arrow, as it's always positive.
There was a problem hiding this comment.
For single-line diagrams, I used the reactive power arrow direction for the current arrow direction. Let me know if it is something I should remove.
There was a problem hiding this comment.
I'd say we'd rather investigate this more before doing so
fix year and author Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
…s reactive power Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
…wer arrow direction Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
approved these changes
Apr 6, 2023
flo-dup
requested changes
Apr 6, 2023
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Apr 6, 2023
BenoitJeanson
pushed a commit
that referenced
this pull request
May 2, 2023
* feature: add current feeder info arrow * new management of edge info for network area diagram: only one type possible among active power, reactive power and current * Change dominant baseline for label: mathematical instead of middle * add unit tests * update test references Signed-off-by: Hervé <herve.quarton@soprasteria.com> Co-authored-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com> Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
BenoitJeanson
pushed a commit
that referenced
this pull request
May 4, 2023
* feature: add current feeder info arrow * new management of edge info for network area diagram: only one type possible among active power, reactive power and current * Change dominant baseline for label: mathematical instead of middle * add unit tests * update test references Signed-off-by: Hervé <herve.quarton@soprasteria.com> Co-authored-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
BenoitJeanson
pushed a commit
that referenced
this pull request
May 4, 2023
* feature: add current feeder info arrow * new management of edge info for network area diagram: only one type possible among active power, reactive power and current * Change dominant baseline for label: mathematical instead of middle * add unit tests * update test references Signed-off-by: Hervé <herve.quarton@soprasteria.com> Co-authored-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Only active and reactive power pieces of information can currently be displayed on the graph.
What is the new behavior (if this is a feature change)?
This PR offers the possibility to display the current piece of information.