New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown component #507

Merged

flo-dup merged 22 commits into main from unknown_component

Apr 4, 2023

Member

So-Fras commented Mar 16, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#506

So-Fras added the SLD label

So-Fras assigned tadam50

flo-dup force-pushed the unknown_component branch from c2c6580 to fe1aef3 Compare

March 20, 2023 15:21

tadam50 force-pushed the unknown_component branch 3 times, most recently from 84a8ca1 to f1b021c Compare

March 24, 2023 10:35

flo-dup reviewed

View reviewed changes

...e-line-diagram/single-line-diagram-core/src/main/resources/FlatDesignLibrary/components.json Outdated Show resolved Hide resolved

So-Fras marked this pull request as ready for review

March 28, 2023 10:12

flo-dup requested changes

View reviewed changes

single-line-diagram/single-line-diagram-core/src/test/resources/TestUnknown.svg Outdated Show resolved Hide resolved

...diagram/single-line-diagram-core/src/main/resources/ConvergenceLibrary/unknown-component.svg Outdated Show resolved Hide resolved

...diagram/single-line-diagram-core/src/main/resources/ConvergenceLibrary/unknown-component.svg Outdated Show resolved Hide resolved

...iagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestUnknownComponent.java Outdated Show resolved Hide resolved

...iagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestUnknownComponent.java Outdated Show resolved Hide resolved

...-diagram/single-line-diagram-core/src/main/resources/FlatDesignLibrary/unknown-component.svg Outdated Show resolved Hide resolved

So-Fras and others added 18 commits

March 30, 2023 16:27


          add unknown component in both ConvergenceLibrary and FlatDesignLibrary

45482de

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>


          first ideas to add an unknown component

69883ff

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>


          Simplify question mark paths

4ac1e9a

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>


          Update reference test files

1689c8a

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Make DefaultSVGWriter insert Unknown component

cecc059

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Add test for Unknown component

af9ab02

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Resize ConvergenceLibrary/unknown-component.svg + remove anchor point…

087c36f

…s + Use mock to use 3wt as unknown component

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Change Anchor points for unknown component + Add unknown Flat test

bcc7e4f

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Update unknown-component.svg to center question mark

4831b05

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Update unknown-component tests

6fd38d5

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Update unknown-component to 20x20

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Update unknown-component test files result

f96b8f9

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Fix tests after main branch merged

c437418

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Precision is too high for what is needed, I simplified it with a prec…

28b7533

…ision of 3

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Use NetworkFactory instead of code duplication

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Remove unused file

0bdf393

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Add in tests UnknownLibrary without 3wt, 2wt & generator

f036452

Signed-off-by: Thomas ADAM <tadam@silicom.fr>


          Fix code smell : rename Outside by Inside and get opposite

9441d75

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

tadam50 force-pushed the unknown_component branch from c70075d to b8c824e Compare

March 30, 2023 14:41


          Fix battery usage after main rebase

721520c

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

tadam50 force-pushed the unknown_component branch from b8c824e to 721520c Compare

March 30, 2023 14:51

tadam50 changed the title ~~[WIP] Unknown component~~ Unknown component

tadam50 requested review from flo-dup and tadam50

March 30, 2023 14:57

flo-dup requested changes

View reviewed changes

...ingle-line-diagram-core/src/main/java/com/powsybl/sld/library/ResourcesComponentLibrary.java Outdated Show resolved Hide resolved


          Rename isInsideVlComponent to isDisplayed

8f30379

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

flo-dup requested changes

View reviewed changes

Contributor

flo-dup left a comment

Still two minor comments and we're good!

single-line-diagram/single-line-diagram-core/src/test/resources/UnknownLibrary/battery.svg Outdated Show resolved Hide resolved

...iagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestUnknownComponent.java Outdated Show resolved Hide resolved


          Keep only usefull component into testing unknown library

b859fb9

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

flo-dup approved these changes

View reviewed changes


          Merge branch 'main' into unknown_component

6bd81c7

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

flo-dup force-pushed the unknown_component branch from 4c84e70 to 6bd81c7 Compare

April 4, 2023 06:51

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

97.5% Coverage
0.0% Duplication

flo-dup merged commit 3d77e70 into main

flo-dup deleted the unknown_component branch

April 4, 2023 07:45

flo-dup linked an issue

that may be closed by this pull request

Display an "unknown component" icon when a component is not found in the component libray #506

Closed

BenoitJeanson pushed a commit that referenced this pull request


          Unknown component (#507)

898c34f

* add unknown component in both ConvergenceLibrary and FlatDesignLibrary
* Update reference test files
* Add test for Unknown component

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Co-authored-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>

BenoitJeanson pushed a commit that referenced this pull request


          Unknown component (#507)

1e840c2

* add unknown component in both ConvergenceLibrary and FlatDesignLibrary
* Update reference test files
* Add test for Unknown component

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Co-authored-by: Thomas ADAM <tadam@silicom.fr>

BenoitJeanson pushed a commit that referenced this pull request


          Unknown component (#507)

58b0974

* add unknown component in both ConvergenceLibrary and FlatDesignLibrary
* Update reference test files
* Add test for Unknown component

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Co-authored-by: Thomas ADAM <tadam@silicom.fr>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SLD