Bump to powsybl-core 5.2.0 and to junit5 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Mar 28, 2023
| @@ -39,7 +39,7 @@ protected AbstractDiagramDataExporter(TripleStore tripleStore, ExportContext con | |||
| } | |||
|
|
|||
| protected String addDiagramObject(String id, String name, double rotation, String diagramObjectStyleId, String diagramId) { | |||
| PropertyBag diagramObjectProperties = new PropertyBag(Arrays.asList(CgmesDLModel.IDENTIFIED_OBJECT_NAME, CgmesDLModel.IDENTIFIED_OBJECT, "rotation", CgmesDLModel.DIAGRAM, CgmesDLModel.DIAGRAM_OBJECT_STYLE)); | |||
| PropertyBag diagramObjectProperties = new PropertyBag(Arrays.asList(CgmesDLModel.IDENTIFIED_OBJECT_NAME, CgmesDLModel.IDENTIFIED_OBJECT, "rotation", CgmesDLModel.DIAGRAM, CgmesDLModel.DIAGRAM_OBJECT_STYLE), true); | |||
There was a problem hiding this comment.
Do we need to decode identifiers?
There was a problem hiding this comment.
I don't know which option is the most suitable. It could be a layout parameter with a default value to true or false instead of a hard-coded value.
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
geofjamg
previously requested changes
Mar 28, 2023
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
changed the title
Signed-off-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Apr 3, 2023
network-area-diagram/pom.xml
Outdated
Comment on lines
87
to
93
| <artifactId>powsybl-loadflow-api</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.powsybl</groupId> | ||
| <artifactId>powsybl-open-loadflow</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
You can remove powsybl-loadflow-api too
|
|
||
| import java.io.IOException; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| /** | ||
| * @author Sophie Frasnedo <sophie.frasnedo at rte-france.com> | ||
| */ | ||
| public class TestBattery extends AbstractTestCaseIidm { |
|
|
||
| import static com.powsybl.sld.model.coordinate.Direction.TOP; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| /** | ||
| * @author Sophie Frasnedo <sophie.frasnedo at rte-france.com> | ||
| */ | ||
| public class TestAddBatteries extends AbstractTestCaseRaw { |
remove public modifier Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
remove public modifier Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
remove powsybl-loadflow-api dependency Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Apr 4, 2023
BenoitJeanson
pushed a commit
that referenced
this pull request
May 2, 2023
* Bump powsybl-core to 5.2.0 * Bump to junit5 * remove olf dependency from nad * update test reference Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com> Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
BenoitJeanson
pushed a commit
that referenced
this pull request
May 4, 2023
* Bump powsybl-core to 5.2.0 * Bump to junit5 * remove olf dependency from nad * update test reference Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
BenoitJeanson
pushed a commit
that referenced
this pull request
May 4, 2023
* Bump powsybl-core to 5.2.0 * Bump to junit5 * remove olf dependency from nad * update test reference Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Dependency update / clean
What is the new behavior (if this is a feature change)?
Bump to JUnit 5
Bump to version 5.2.0 of powsybl-core
Remove open-loadflow dependency to avoid updating unit tests when loadflow and/or test networks have been changed
Does this PR introduce a breaking change or deprecate an API?
No