-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Java 17 #528
Update to Java 17 #528
Conversation
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Now I think about it, is there a reason to have a conditional test for the Java version? Once we switch to Java 17, will users be able to run tests with older Java versions anyway? |
You are right, the conditional test was only to prepare the Java 17 upgrade. Since this PR covers also the upgrade, the Java 11 alternative would never be reached.
As we will soon merge the |
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
...ine-diagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestFeederInfos.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
… version Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Update to Java 17
A test had to be modified in order to pass when run with Java 17 (French thousand separator was changed from Non-breakable space - NBSP - to Narrow non-breakable space - NNBSP - in Java 13 due to CLDR 35.1 support).
Does this PR introduce a breaking change or deprecate an API?
Yes