Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java 17 #528

Merged
merged 10 commits into from
Jul 21, 2023
Merged

Update to Java 17 #528

merged 10 commits into from
Jul 21, 2023

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Jul 3, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Update to Java 17
A test had to be modified in order to pass when run with Java 17 (French thousand separator was changed from Non-breakable space - NBSP - to Narrow non-breakable space - NNBSP - in Java 13 due to CLDR 35.1 support).

Does this PR introduce a breaking change or deprecate an API?
Yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras requested a review from olperr1 July 3, 2023 14:55
@So-Fras So-Fras self-assigned this Jul 3, 2023
@So-Fras So-Fras changed the title Update to Java 17 [WIP] Update to Java 17 Jul 3, 2023
So-Fras added 2 commits July 4, 2023 09:40
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras changed the title [WIP] Update to Java 17 Update to Java 17 Jul 4, 2023
@So-Fras
Copy link
Member Author

So-Fras commented Jul 4, 2023

Now I think about it, is there a reason to have a conditional test for the Java version? Once we switch to Java 17, will users be able to run tests with older Java versions anyway?

@olperr1
Copy link
Member

olperr1 commented Jul 4, 2023

Now I think about it, is there a reason to have a conditional test for the Java version? Once we switch to Java 17, will users be able to run tests with older Java versions anyway?

You are right, the conditional test was only to prepare the Java 17 upgrade. Since this PR covers also the upgrade, the Java 11 alternative would never be reached.
Thus we could either:

  • remove the java11 branch;
  • split this PR in 2 (the test adaptation + the java17 upgrade), if we want to defer the upgrade in powsybl-diagram.

As we will soon merge the powsybl-core java 17 upgrade, it's maybe easier to choose the first alternative.

So-Fras added 2 commits July 4, 2023 11:26
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
So-Fras added 3 commits July 21, 2023 13:36
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
… version

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olperr1 olperr1 merged commit 5e6600b into main Jul 21, 2023
@olperr1 olperr1 deleted the java17 branch July 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants