Update CI actions due to node.js v12 deprecation #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
rolnico
approved these changes
Nov 22, 2023
flo-dup
reviewed
Dec 4, 2023
.github/workflows/maven.yml
Outdated
| @@ -18,12 +18,12 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Checkout sources | |||
| uses: actions/checkout@v2.3.4 | |||
| uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
you need to put the hash corresponding to the release, as the tag might be changed by an attacker
There was a problem hiding this comment.
You can look at powsybl/powsybl-core#2821 for an example
There was a problem hiding this comment.
Ok, thanks for pointing it out. I took more recent version too, following the example in core:
- 4.1.1 for actions/checkout instead of 4
- 4.0.0 for actions/setup-java instead of 3
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
approved these changes
Dec 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No but similar to this PR on powsybl-core : powsybl/powsybl-core#2766
What kind of change does this PR introduce?
What is the current behavior?
CI was using setup-java v2 and checkout v2.3.4
What is the new behavior (if this is a feature change)?
CI is now using setup-java v3 and checkout v4