Matrix zone layout : fix diagram padding usage #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadam50
force-pushed
the
matrix-zone-diagram-padding
branch
from
453f4d9 to
c3d4c62
Compare
|
So-Fras
requested changes
Feb 26, 2024
|
|
||
| public MatrixZoneLayoutModel(String[][] ids, LayoutParameters layoutParameters) { | ||
| this.matrix = new Matrix(ids.length, ids[0].length, layoutParameters); | ||
| this.snakelinePadding = (int) layoutParameters.getZoneLayoutSnakeLinePadding(); |
There was a problem hiding this comment.
Is there a need to have a type double for zoneLayoutSnakeLinePadding since we always seem to cast it to int ?
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
tadam50
force-pushed
the
matrix-zone-diagram-padding
branch
from
c3d4c62 to
bfdc273
Compare
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
|
So-Fras
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Diagram padding is no taking into account in Zone Matrix Layout
What is the new behavior (if this is a feature change)?
Diagram padding is taking into account in Zone Matrix Layout
Does this PR introduce a breaking change or deprecate an API?