Add parameter to disable/enable internal 2wt #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
1 task
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
geofjamg
approved these changes
Mar 14, 2024
So-Fras
requested changes
Mar 14, 2024
| // Run layout with specific parameters and compare subsequent SVG with reference | ||
| PositionVoltageLevelLayoutFactoryParameters pvllfParameters = new PositionVoltageLevelLayoutFactoryParameters() | ||
| .setSubstituteInternalMiddle2wtByEquipmentNodes(false); | ||
| new PositionVoltageLevelLayoutFactory(new PositionFromExtension(), pvllfParameters).create(g).run(this.layoutParameters); |
There was a problem hiding this comment.
Suggested change
| new PositionVoltageLevelLayoutFactory(new PositionFromExtension(), pvllfParameters).create(g).run(this.layoutParameters); | |
| new PositionVoltageLevelLayoutFactory(pvllfParameters).create(g).run(this.layoutParameters); |
There was a problem hiding this comment.
I prefer to put this explicitly, as this default choice does not seem clear to me. And I'd like to remove one day that constructor which assumes that it should be a PositionFromExtension by default (without any javadoc specifying it!)
...le-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestInternalBranchesNodeBreaker.java
Outdated
Show resolved
Hide resolved
…/powsybl/sld/iidm/TestInternalBranchesNodeBreaker.java Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com> Signed-off-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com>
|
So-Fras
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix / feature
What is the current behavior?
Internal two-winding transformers and phase-shift transformers are added in VoltageLevelGraph as
EquipmentNodes, hence are withing an InternCell or ExternCell.What is the new behavior (if this is a feature change)?
Internal two-winding transformers and phase-shift transformers are added in VoltageLevelGraph as
FeederNodes, but can be later replaced byEquipmentNodes with VoltageLevelLayoutFactoryParameter::setSubstituteInternalMiddle2wtByEquipmentNodes`. This parameter is true by default.Other information:
NetworkGraphBuilder::handleConnectedComponents(together with child methodNetworkGraphBuilder::ensureOneBusInConnectedComponent) needed to move toGraphRefinerin order not to interfere with this feature