Fix one leg intern cells #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
So-Fras
requested changes
Mar 20, 2024
| List<LegPrimaryBlock> subBlocks = legParallelBlock.getSubBlocks(); | ||
| if (subBlocks.size() == 2) { | ||
| internCell.replaceOneLegByMultiLeg(subBlocks.get(0), subBlocks.get(1)); | ||
| } else { |
There was a problem hiding this comment.
This else statement is never used (neither in unit tests nor in other tests I ran with French substations).
Shall we remove it?
There was a problem hiding this comment.
Now there's one unit test which uses it. And I fixed the content of the else, adding comments to explain better what's done.
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
maybe_one_leg
branch
3 times, most recently
from
bc1ab03 to
356a1c8
Compare
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
So-Fras
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
One-leg intern cells, which are intern cells which are displayed as a single vertical line, forces the corresponding busbars to be parallel, which used to lead to unexpected behaviour (mixing components on one of the two bars). Since PR #573, an exception is thrown.
Example of one-leg intern cell from unit tests:
What is the new behavior (if this is a feature change)?
MAYBE_ONE_LEGONE_LEGUNDEFINEDorMAYBE_FLATUNDEFINEDorMAYBE_FLATONE_LEGONE_LEGNote that when splitting in two parts the subBlocks of the internCell, we favour the splitting based on LegBusSets as they can deal with complex subsections which contain more than one sectionIndex (e.g., two parallel busbars with different lengths).
Does this PR introduce a breaking change or deprecate an API?