Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty node set exception #596

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Fix empty node set exception #596

merged 8 commits into from
Mar 26, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Mar 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
If the voltage level drawn contains a connected component with no fictitious node, a exception is thrown

What is the new behavior (if this is a feature change)?
If the voltage level drawn contains a connected component with no fictitious node, a fictitious BusNode is added to the first node of the connected component set (sorted in alphabetical order)

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

flo-dup added 3 commits March 25, 2024 17:27
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from So-Fras March 26, 2024 09:33
So-Fras and others added 5 commits March 26, 2024 11:02
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link

@So-Fras So-Fras merged commit 55ca400 into main Mar 26, 2024
6 checks passed
@So-Fras So-Fras deleted the fix_empty_node_set branch March 26, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants