Add edge type to metadata in network area diagram SVG #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
reviewed
May 3, 2024
| graph.getThreeWtEdgesStream().forEach(edge -> metadata.addEdge(getPrefixedId(edge.getDiagramId()), edge.getEquipmentId(), | ||
| getPrefixedId(graph.getNode1(edge).getDiagramId()), | ||
| getPrefixedId(graph.getNode2(edge).getDiagramId()), | ||
| getPrefixedId(graph.getBusGraphNode1(edge).getDiagramId()), | ||
| getPrefixedId(graph.getBusGraphNode2(edge).getDiagramId()))); | ||
| getPrefixedId(graph.getBusGraphNode2(edge).getDiagramId()), | ||
| "ThreeWtEdge")); |
There was a problem hiding this comment.
It would be cleaner if ThreeWtEdge holds that string type.
In fact we should move the type attribute which is in BranchEdge in AbstractEdge, and add getType() method in the Edge empty interface. Could you do such a change in this PR?
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
|
flo-dup
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the new behavior (if this is a feature change)?
Information about the edge type has been added to the metadata in the network area diagram SVG
Does this PR introduce a breaking change or deprecate an API?