Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAD] Unknown bus corner cases #619

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 31, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Add unit test

What is the current behavior?
No unit test with one unknown bus in a voltage level which has other buses

What is the new behavior (if this is a feature change)?
A unit test with one unknown bus in a voltage level which has other buses

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup added the NAD label May 31, 2024
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link

@flo-dup flo-dup merged commit a53c42d into main Jun 19, 2024
7 checks passed
@flo-dup flo-dup deleted the add_unknown_bus_corner_case_unit_test branch June 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants