Add voltage level details to display production and consumption figures #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
… to voltage level details Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
So-Fras
changed the title
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
So-Fras
changed the title
flo-dup
reviewed
Jul 2, 2024
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
flo-dup
reviewed
Jul 2, 2024
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Jul 3, 2024
| List<String> voltageLevelDetails = new ArrayList<>(); | ||
| VoltageLevel voltageLevel = network.getVoltageLevel(vlNode.getEquipmentId()); | ||
|
|
||
| double activeProductionValue = voltageLevel.getGeneratorStream().mapToDouble(generator -> !Double.isNaN(-generator.getTerminal().getP()) ? -generator.getTerminal().getP() : 0).sum(); |
There was a problem hiding this comment.
This stream operation (and the 3 others) can be simplified that way. Besides it will avoid the complexity issue raised by sonar.
Suggested change
| double activeProductionValue = voltageLevel.getGeneratorStream().mapToDouble(generator -> !Double.isNaN(-generator.getTerminal().getP()) ? -generator.getTerminal().getP() : 0).sum(); | |
| double activeProductionValue = voltageLevel.getGeneratorStream().mapToDouble(generator -> -generator.getTerminal().getP()).filter(p -> !Double.isNaN(p)).sum(); |
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
|
flo-dup
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?