Fix GraphMetadata serialization: attributes' order #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
On some systems, the export order of
GraphMetadata
attributes is determined by the order of the 1st encounteredJsonCreator
's attributes andunescapedId
is put in last place.But on other systems, the export order is determined by the getters' order and
unescapedId
is put in 1st place, which leads to comparison errors in the unit tests.What is the new behavior (if this is a feature change)?
To prevent this discrepancy, the order is manually fixed.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
This problem was spotted via the pypowsybl "Snapshot CI" action. The problem occurs for the following jobs: