Simplify synchronous generator models declaration #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbdr
changed the title
dimbdr
force-pushed
the
simplify_generators
branch
from
881a20c to
16f3a45
Compare
dimbdr
commented
Dec 21, 2022
...src/main/groovy/com/powsybl/dynawaltz/dsl/dynamicmodels/GeneratorModelGroovyExtension.groovy
Outdated
Show resolved
Hide resolved
dimbdr
force-pushed
the
simplify_generators
branch
from
16f3a45 to
140fc29
Compare
added 2 commits
December 22, 2022 11:28
The only thing that distinguishes a synchronous generator from another is the lib. Then it's just an attribute Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dimbdr
force-pushed
the
simplify_generators
branch
from
140fc29 to
d527920
Compare
added 3 commits
December 22, 2022 15:27
…n file. Problem: right order of generators is not guaranteed Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
# Conflicts: # dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/models/generators/GeneratorSynchronousFourWindingsGroovyExtension.groovy # dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/models/generators/GeneratorSynchronousFourWindingsProportionalRegulationsGroovyExtension.groovy # dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/models/generators/GeneratorSynchronousFourWindingsProportionalRegulationsStepPmGroovyExtension.groovy # dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/models/generators/GeneratorSynchronousThreeWindingsGroovyExtension.groovy # dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/models/generators/GeneratorSynchronousThreeWindingsProportionalRegulationsGroovyExtension.groovy # dynawaltz-dsl/src/test/java/com/powsybl/dynawaltz/dsl/DynaWaltzGroovyDynamicModelsSupplierTest.java
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dimbdr
changed the title
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
flo-dup
reviewed
Jan 4, 2023
| @AutoService(DynamicModelGroovyExtension.class) | ||
| class GeneratorModelGroovyExtension implements DynamicModelGroovyExtension { | ||
|
|
||
| private static final String GENERATORS_CONFIG = "synchronous_generators.cfg"; |
There was a problem hiding this comment.
How could we extend this, to add more generators than current ones?
It would be more flexible to be able to set that file.
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Jan 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Creating synchronous generator model is redundant, we want to have a way to allocate as many different synchronous generators as necessary, but with a configuration file.
It's a proposal on how to answer to this problem.