Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Dynawo version in Security analysis and Dynawaltz provider #171

Merged
merged 13 commits into from
Mar 9, 2023

Conversation

Lisrte
Copy link
Collaborator

@Lisrte Lisrte commented Feb 3, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#170

…rovider

Use PowSyBl-Dynawo version for the Dynawaltz provider version
Fix checkstyle
Add unitary tests

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte linked an issue Feb 3, 2023 that may be closed by this pull request
…rovider

Use PowSyBl-Dynawo version for the Dynawaltz provider version
Fix checkstyle
Add unitary tests

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the missing-dynawo-version-check branch from 6f5288c to 610354e Compare February 6, 2023 12:34
Lisrte and others added 6 commits February 6, 2023 13:47
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
…sybl/powsybl-dynawo into missing-dynawo-version-check

# Conflicts:
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/DynaWaltzProviderTest.java
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment!

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the missing-dynawo-version-check branch from 5a6465c to 53da0e6 Compare March 9, 2023 10:05
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the missing-dynawo-version-check branch from 53da0e6 to f525d19 Compare March 9, 2023 10:06
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit ee1648d into main Mar 9, 2023
@flo-dup flo-dup deleted the missing-dynawo-version-check branch March 9, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dynawo version check & wrong Dynawaltz provider version
2 participants