Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bus and line models #177

Merged
merged 11 commits into from
Mar 21, 2023
Merged

Fix bus and line models #177

merged 11 commits into from
Mar 21, 2023

Conversation

gautierbureau
Copy link
Member

@gautierbureau gautierbureau commented Feb 14, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
StandardBus/StandardLine model connections and connections to it are wrong

What is the new behavior (if this is a feature change)?
StandardBus/StandardLine model connections and connections to it are fixed

Does this PR introduce a breaking change or deprecate an API?
No

@gautierbureau gautierbureau marked this pull request as draft February 14, 2023 13:35
@flo-dup flo-dup marked this pull request as ready for review March 14, 2023 21:47
@flo-dup flo-dup changed the base branch from main to fix_standard_line March 15, 2023 08:58
flo-dup added 6 commits March 17, 2023 18:20
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the fix_standard_line branch from 6799a7d to 248c53f Compare March 17, 2023 17:25
@flo-dup flo-dup changed the base branch from fix_standard_line to main March 17, 2023 17:25
@flo-dup flo-dup changed the title Fix bus model. Fix bus and line models Mar 17, 2023
@flo-dup flo-dup mentioned this pull request Mar 17, 2023
3 tasks
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from Lisrte March 20, 2023 09:12
flo-dup added 2 commits March 21, 2023 11:25
This reverts commit 6395127.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added 2 commits March 21, 2023 17:21
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.9% 91.9% Coverage
12.9% 12.9% Duplication

@flo-dup flo-dup merged commit 1a5c7f4 into main Mar 21, 2023
@flo-dup flo-dup deleted the fix_bus_model branch March 21, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants