Refactor disconnection events #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/DefaultGeneratorModel.java
Outdated
Show resolved
Hide resolved
…ripole Handle quadripole disconnection Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Add UT Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Add disconnection UT Add default model Load Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Fix UT Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Lisrte
force-pushed
the
refactor_disconnection_events
branch
from
2ebbd29 to
a322bd0
Compare
flo-dup
requested changes
Apr 20, 2023
...sl/src/main/groovy/com/powsybl/dynawaltz/dsl/events/EventDisconnectionGroovyExtension.groovy
Outdated
Show resolved
Hide resolved
dynawaltz/src/main/java/com/powsybl/dynawaltz/DynaWaltzContext.java
Outdated
Show resolved
Hide resolved
dynawaltz/src/main/java/com/powsybl/dynawaltz/models/events/EventQuadripoleDisconnection.java
Outdated
Show resolved
Hide resolved
| this.stateEvent = stateEvent; | ||
| private final boolean disconnect; | ||
|
|
||
| public EventSetPointBoolean(Generator equipment, double startTime, boolean disconnect) { |
There was a problem hiding this comment.
@gautierbureau I'm wondering if we shouldn't put Injection<?> instead, to include more equipments (SVC, converter stations, shunt compensators, dangling lines, busbar sections, batteries). Or are we interested only in disconnecting loads and generators so far?
dynawaltz/src/main/java/com/powsybl/dynawaltz/models/events/EventSetPointBoolean.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Refactor
What is the current behavior?
What is the new behavior (if this is a feature change)?
In DSL, replace EventSetPointBoolean and EventQuadripoleDisconnection with a common tag Disconnect
Add the possibility to disconnect transformer and load
Does this PR introduce a breaking change or deprecate an API?
Other information: