Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation #410

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Add missing documentation #410

merged 7 commits into from
Dec 13, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 20, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Docs update

What is the current behavior?

What is the new behavior (if this is a feature change)?
Add the different models suppliers definition.
Add missing event and dynamic model description.
Update of Dynaflow parameters documentation based on DynaFlowLauncherDocumentation
Reorder parameter documentation

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Add missing event and dynamic model description.
Update of Dynaflow parameters documentation based on DynaFlowLauncherDocumentation
Reorder parameter documentation

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte requested a review from flo-dup November 20, 2024 13:11
@Lisrte Lisrte self-assigned this Nov 20, 2024
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
docs/dynamic_simulation/configuration.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/event-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/index.md Show resolved Hide resolved
docs/load_flow/configuration.md Outdated Show resolved Hide resolved
docs/load_flow/configuration.md Outdated Show resolved Hide resolved
docs/load_flow/configuration.md Outdated Show resolved Hide resolved
So-Fras
So-Fras previously requested changes Dec 2, 2024
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the documentation, it is greatly appreciated! I left some minor comments.

docs/dynamic_security_analysis/index.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/event-models-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/output-variables-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/output-variables-mapping.md Outdated Show resolved Hide resolved
docs/dynamic_simulation/output-variables-mapping.md Outdated Show resolved Hide resolved
Lisrte and others added 4 commits December 12, 2024 17:03
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
# Conflicts:
#	docs/dynamic_simulation/event-models-dsl.md
#	dynawo-simulation/src/main/java/com/powsybl/dynawo/models/events/EventDisconnectionBuilder.java
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
dynawo-simulation/src/main/resources/models.json Outdated Show resolved Hide resolved
docs/dynamic_simulation/dynamic-models-mapping.md Outdated Show resolved Hide resolved
Signed-off-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com>
@flo-dup flo-dup dismissed So-Fras’s stale review December 13, 2024 09:09

changes requested have been done

@flo-dup flo-dup merged commit e226a1d into main Dec 13, 2024
8 checks passed
@flo-dup flo-dup deleted the update_documentation branch December 13, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants