Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete results with limit violations from DynaFlow #98

Merged
merged 35 commits into from
Apr 4, 2023
Merged

Conversation

marcosmc
Copy link
Contributor

@marcosmc marcosmc commented Dec 1, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix / feature

What is the current behavior?
Security analysis results are expected to be written in powsybl format by dynawo. This output format is not planned in dynawo.

What is the new behavior (if this is a feature change)?
dynawo formatted constraints results files are read and security analysis results are build based on these files

Does this PR introduce a breaking change or deprecate an API?
No

marcosmc and others added 6 commits December 1, 2021 13:35
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Copy link
Contributor

flo-dup commented Feb 1, 2023

We need to look for the precontingency constraint file... but it doesn't seem to be in dynawo's outputs

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Instead of corresponding contingency folders

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@powsybl powsybl deleted a comment from sonarqubecloud bot Feb 23, 2023
@powsybl powsybl deleted a comment from sonarqubecloud bot Feb 23, 2023
flo-dup and others added 10 commits March 10, 2023 16:07
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
…)"

This reverts commit 374e117.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup marked this pull request as ready for review March 22, 2023 15:26
@flo-dup
Copy link
Contributor

flo-dup commented Mar 22, 2023

We need to look for the precontingency constraint file... but it doesn't seem to be in dynawo's outputs

Not planned so far to be in the outputs. When running dynaflow security analysis one needs to launch a loadflow beforehand.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added 3 commits March 23, 2023 14:32
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup and others added 3 commits March 23, 2023 22:27
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added 2 commits March 24, 2023 14:49
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from gautierbureau March 24, 2023 13:52
flo-dup and others added 7 commits April 4, 2023 11:22
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 2f3264d into main Apr 4, 2023
@flo-dup flo-dup deleted the constraints branch April 4, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants