Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding total mismatch in the error message #102

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Adding total mismatch in the error message #102

merged 2 commits into from
Jun 1, 2023

Conversation

WalAmeni
Copy link
Contributor

@WalAmeni WalAmeni commented Jun 1, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

In case of failure, it's useful to have the final mismatch of the balances adjustement in the error message to let the user increase the threshold parameter

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Ameni Walha <ameni.walha@rte-france.com>
@WalAmeni WalAmeni requested a review from phiedw June 1, 2023 13:47
Signed-off-by: Ameni Walha <ameni.walha@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phiedw phiedw merged commit 5427afc into main Jun 1, 2023
@phiedw phiedw deleted the add_mismatch_log branch June 1, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants