Add max value for hybrid glsks #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather than the generators Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
correctly use min and max values for hybrid glsks Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
… hybrid_scalable_max Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
|
schwitzguebel
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature / bug fix
What is the current behavior?
Currently, we compute a max on each of the generators from the proportional scalable (by multiplying the max value for the whole glsk by the proportion of each generator). This is not quite correct though if we scale while trying to respect the volume asked for a scale, in the case where some generators become saturated (the remainder can not be added to the other generators because of the max value applied to each generator)
What is the new behavior (if this is a feature change)?
With the new API in powsybl core, it is now possible to define a max on a proportional scalable. This replaces the old max we used to put per generator (in this case precisely)
Does this PR introduce a breaking change or deprecate an API?