handle load in merit order conversion #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Theo Pascoli <theo.pascoli@rte-france.com>
schwitzguebel
approved these changes
Jan 4, 2024
kahyami
approved these changes
Jan 4, 2024
phiedw
requested changes
Jan 4, 2024
glsk/glsk-document-cse/src/test/java/com/powsybl/glsk/cse/CseGlskDocumentImporterTest.java
Show resolved
Hide resolved
Signed-off-by: Theo Pascoli <theo.pascoli@rte-france.com>
|
phiedw
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior?
In the merit order conversion, everything that is not a generator is considered a dangline line. I had the case where a load would be seen as a dangline line and would trigger a null pointer exception
What is the new behavior (if this is a feature change)?
I add a check to verify if a glskShiftKey is a generator, a load, or a dangline line
Does this PR introduce a breaking change or deprecate an API?