Bump to core 6.3.0 and olf 1.9.0 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
annetill
changed the base branch from
main
to
update_balance_adjustment_tests_after_olf_writeslacks_true_by_default
annetill
changed the title
annetill
reviewed
Mar 29, 2024
.github/workflows/maven.yml
Outdated
| @@ -29,7 +29,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| repository: powsybl/powsybl-core | |||
| ref: refs/heads/main | |||
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
changed the title
annetill
changed the base branch from
update_balance_adjustment_tests_after_olf_writeslacks_true_by_default
to
main
annetill
changed the title
-Clean maven.yml. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
This was referenced Apr 4, 2024
|
annetill
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Update tests
What is the current behavior?
Previously, when a Common Grid Model (CGM) was exported as a single network the tie lines were exported as a single equipment.
The change introduced in powsybl/powsybl-core#2619 update the export of CGM, keeping in the export the two ACLSs that are inside a tie line.
What is the new behavior (if this is a feature change)?
The unit test that checked the CGM export converted the tie lines to regular lines in the original network (the "expected" value of the tests) to be able to compare it with the "actual" exported CGM without errors.
This change is not required anymore.
When the CGM is exported as a single network the (p0, q0) values of the dangling lines inside tie lines are not relevant (as the whole tie line will be exported and re-imported).
Does this PR introduce a breaking change or deprecate an API?
Other information: