Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute losses evenly when calculating the net position for paired dangling lines #161

Closed
wants to merge 2 commits into from

Conversation

caioluke
Copy link
Member

@caioluke caioluke commented Sep 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature

What is the current behavior?

Losses for paired dangling lines are not split equally in net position calculation. As a consequence, the sum of all net positions of a closed network is not 0.

What is the new behavior (if this is a feature change)?
Paired dangling lines (tie lines) are treated like normal lines in net position calculation.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Caio Luke <caioluke97@gmail.com>
@caioluke caioluke requested a review from OpenSuze September 23, 2024 08:58
@caioluke caioluke self-assigned this Sep 23, 2024
Copy link
Contributor

@OpenSuze OpenSuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

Could you rename it to "Distribute losses evenly when calculating the net position for paired dangling lines" please ?

Thank you

@caioluke caioluke changed the title Split losses equally in net position calculation for paired dangling lines Distribute losses evenly when calculating the net position for paired dangling lines Sep 23, 2024
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Copy link

Copy link
Contributor

@OpenSuze OpenSuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a bit of time to reconsider this PR.
I think that we had a miss-understanding about losses and leaving flow contributions to net positions.

After thinking about this, we do not think that this is a good idea to distribute the tie-line flow evenly without considering their dangling lines properties.
For example, we do not think this is fair to distribute the flow evenly for an interconnection composed of a section line of 15km in a first country and another section of 5km in another country.
We believe it might be better to keep the current behavior.

I do not want to delete your work.

We will work on another idea based on danglingLine.getBoundary()

@OpenSuze
Copy link
Contributor

OpenSuze commented Oct 1, 2024

We might have found some issues with the power on each side of a boundary. I'm trying to fix this, but it might take a while powsybl/powsybl-core#3165

@OpenSuze
Copy link
Contributor

OpenSuze commented Oct 8, 2024

Hi @caioluke,
I made another PR based on your commit: #164
Could you review it please ?

@caioluke
Copy link
Member Author

caioluke commented Oct 8, 2024

Sure thing.

I will close this one, then.

What I wanted to achieve with this PR was precisely the sum of net positions in a closed network being 0.
I thought it was a loss issue but it turned out to be a boundary issue.

Thanks for the help, Hugo!

@caioluke caioluke closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants