-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute losses evenly when calculating the net position for paired dangling lines #161
Conversation
Signed-off-by: Caio Luke <caioluke97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR !
Could you rename it to "Distribute losses evenly when calculating the net position for paired dangling lines" please ?
Thank you
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetPositionComputer.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/test/java/com/powsybl/flow_decomposition/NetPositionTest.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetPositionComputer.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/test/java/com/powsybl/flow_decomposition/NetPositionTest.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/test/java/com/powsybl/flow_decomposition/NetPositionTest.java
Show resolved
Hide resolved
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a bit of time to reconsider this PR.
I think that we had a miss-understanding about losses and leaving flow contributions to net positions.
After thinking about this, we do not think that this is a good idea to distribute the tie-line flow evenly without considering their dangling lines properties.
For example, we do not think this is fair to distribute the flow evenly for an interconnection composed of a section line of 15km in a first country and another section of 5km in another country.
We believe it might be better to keep the current behavior.
I do not want to delete your work.
We will work on another idea based on danglingLine.getBoundary()
We might have found some issues with the power on each side of a boundary. I'm trying to fix this, but it might take a while powsybl/powsybl-core#3165 |
Sure thing. I will close this one, then. What I wanted to achieve with this PR was precisely the sum of net positions in a closed network being 0. Thanks for the help, Hugo! |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Losses for paired dangling lines are not split equally in net position calculation. As a consequence, the sum of all net positions of a closed network is not 0.
What is the new behavior (if this is a feature change)?
Paired dangling lines (tie lines) are treated like normal lines in net position calculation.
Does this PR introduce a breaking change or deprecate an API?