Flow decomposition observers refactoring #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
OpenSuze
approved these changes
Oct 18, 2024
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionObserver.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionObserver.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionObserver.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionObserver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Caio Luke <caioluke97@gmail.com>
5 tasks
OpenSuze
reviewed
Oct 18, 2024
|
|
||
| // Losses compensation | ||
| compensateLosses(network); | ||
|
|
||
| // DC load flow | ||
| runDcLoadFlow(network); | ||
| saveDcReferenceFlow(flowDecompositionResultsBuilder, network, xnecList); | ||
| saveDcLoadFlowResults(flowDecompositionResultsBuilder, network, xnecList, loadFlowServiceAcResult); |
There was a problem hiding this comment.
Are you sure about using loadFlowServiceAcResult here ... ?
Comment on lines
86
to
88
| if (observers.isEmpty()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think some of those tests are not relevant anymore (line 86 and 96 for example)
There was a problem hiding this comment.
You are right, well spotted
There was a problem hiding this comment.
Could you test the loadFlowResult ? At least that they are not null ?
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
|
OpenSuze
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently, while running a flow decomposition, we can only retrieve intermediate results for branches and nodes. We can't retrieve an intermediate state for a boundary node, for example.
What is the new behavior (if this is a feature change)?
Flow decomposition observers now have full access to the network after an AC LF and a DC LF. Therefore, the user can retrieve any information they need from the network at those states.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Implement the new methods from the FlowDecompositionObserver interface
As well as remove the old ones