Enable negative P0 through scalable for loads #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joris Mancini <joris.mancini@rte-france.com>
miovd
reviewed
Apr 6, 2022
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com> # Conflicts: # glsk/glsk-document-api/src/main/java/com/powsybl/glsk/api/util/converters/GlskPointScalableConverter.java
miovd
added
PR: ready-to-be-merged
and removed
PR: conflict-with-master
PR: waiting-for-test
labels
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joris Mancini joris.mancini@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
We want to enable loads to have a negative P0. For those, which are defined implicitly (meaning with no direct reference to a node) they would have an infinite range (negative and positive). On the other hand for those that are explicitly defined either minimum and maximum values are specified in the format or an infinite range would be adopted.
For GeneratorScalable, the default constructor defines infinite range by default but for LoadScalable it is defined as [0, +inf[ by default. Then we have to specify the infinite range for loads.