Avoid NPE in CSE GLSK import #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 12, 2022 17:56
Signed-off-by: Joris Mancini <joris.mancini@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
miovd
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What is the current behavior? (You can also link to an open issue here)
Some items are searched in the XML but there are checks on the presence of these items then it could cause NPE.
What is the new behavior (if this is a feature change)?
Trying to catch these issues and send proper GLSKException instead.