Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rescaling #39

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Fix rescaling #39

merged 3 commits into from
Jul 25, 2022

Conversation

OpenSuze
Copy link
Contributor

@OpenSuze OpenSuze commented Jul 20, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Fix recaling behavior when the reference flows are of different signs.

What is the current behavior? (You can also link to an open issue here)
Before rescaling, the sum of decomposed flow is different from the DC Reference flow.
After rescaling, the sum of decomposed flow is different from the AC Reference flow.

What is the new behavior (if this is a feature change)?
Before rescaling, the sum of decomposed flow is equal to the DC Reference flow (fixed in OLF in 0.22).
After rescaling, the sum of decomposed flow is equal to the AC Reference flow (fixed in the module).

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:
Require OLF version change from 0.21 to 0.22

(if any of the questions/checkboxes don't apply, please delete them entirely)

@OpenSuze OpenSuze added the Breaking change API is broken label Jul 20, 2022
@OpenSuze OpenSuze changed the title Upgrade OLF and fix rescaling Fix rescaling Jul 22, 2022
@OpenSuze OpenSuze removed the Breaking change API is broken label Jul 22, 2022
@OpenSuze OpenSuze changed the title Fix rescaling [WIP] Fix rescaling Jul 22, 2022
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
@OpenSuze OpenSuze force-pushed the upgrade_olf_and_fix_rescaling branch from 6d5aa05 to 634109e Compare July 22, 2022 12:42
Copy link
Contributor

@murgeyseb murgeyseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be merged after OLF 0.22 is available to make the test succedd

OpenSuze added 2 commits July 25, 2022 15:11
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
@OpenSuze OpenSuze changed the title [WIP] Fix rescaling Fix rescaling Jul 25, 2022
@geofjamg geofjamg merged commit eeb3430 into main Jul 25, 2022
@geofjamg geofjamg deleted the upgrade_olf_and_fix_rescaling branch July 25, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants