Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5% ptdf branch selection #45

Merged
merged 11 commits into from
Aug 29, 2022
Merged

Add 5% ptdf branch selection #45

merged 11 commits into from
Aug 29, 2022

Conversation

OpenSuze
Copy link
Contributor

@OpenSuze OpenSuze commented Jul 28, 2022

Signed-off-by: Hugo SCHINDLER hugo.schindler@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces 5% zonal PTDF branch selection.
This is tested with an hand crafted network.

What is the current behavior? (You can also link to an open issue here)
A branch is selected if it is an interconnection.

What is the new behavior (if this is a feature change)?
A branch is selected if it is an interconnection or if it has a zone zone PTDF greater than 5%.
We can disable zonal PTDF computation as it might be expensive in computation time.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:
Require #44
Internal documentation updated
(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
@OpenSuze OpenSuze changed the title [WIP] Add 5% ptdf branch selection Add 5% ptdf branch selection Jul 29, 2022
@murgeyseb
Copy link
Contributor

@OpenSuze Implement it as a strategy pattern fir the xnec selector. Parameter should not be the strange boolean you added, but a xnec selection strategy enum that has two options : all interconnectors, or on 5 percents ptdf criteria.

@OpenSuze OpenSuze mentioned this pull request Aug 1, 2022
5 tasks
@OpenSuze OpenSuze requested review from pet-mit and phiedw August 8, 2022 09:03
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Balance generator and loads on the Dangling line example

Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
* Add tests on newly added parameter
* Remove extra space

Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

93.7% 93.7% Coverage
0.0% 0.0% Duplication

@murgeyseb murgeyseb merged commit c3e325a into main Aug 29, 2022
@murgeyseb murgeyseb deleted the 5perc_ptdf branch August 29, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants